Add save_text/read_text methods and fix open_file write-mode bugs#4
Merged
Add save_text/read_text methods and fix open_file write-mode bugs#4
Conversation
- Add save_text(filename, str, encoding) to StorageBackend protocol, LocalStorageBackend, S3StorageBackend, and TaskContext - Add read_text(filename, encoding) convenience to TaskContext - Guard open_file against write modes (w/a/x) in both backends with ValueError; previously Local silently bypassed all safety checks and S3 silently ignored writes entirely - Add tests: save_text round-trip, write-once, protected-file, encoding, written_files tracking, open_file write-mode rejection https://claude.ai/code/session_0195vE8XNA52GbQqGBf4xNcL
CHANGELOG: document save_text/read_text addition and open_file write-mode
fix under v0.2.0 new features.
DESIGN.md:
- Remove historical/change-oriented language ("Early versions", "Before
this change", "The original ... was") and restate each section in
terms of the current design only
- Remove the "Future: Redis-based progress" section (speculative, not
implemented)
- Add "File write methods" table under the file-communication section,
documenting all four save_* methods and their OutputFile.file_type
correspondence
https://claude.ai/code/session_0195vE8XNA52GbQqGBf4xNcL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalStorageBackend, S3StorageBackend, and TaskContext
ValueError; previously Local silently bypassed all safety checks
and S3 silently ignored writes entirely
written_files tracking, open_file write-mode rejection
https://claude.ai/code/session_0195vE8XNA52GbQqGBf4xNcL