Skip to content

doc(max_exec_time): set by default to 30s#186

Merged
mga-chka merged 1 commit intomasterfrom
doc/change-following-breaking-change
Jul 13, 2022
Merged

doc(max_exec_time): set by default to 30s#186
mga-chka merged 1 commit intomasterfrom
doc/change-following-breaking-change

Conversation

@gontarzpawel
Copy link
Contributor

@gontarzpawel gontarzpawel commented Jul 13, 2022

Description

We've introduced a change of behaviour of default max_execution_time of query. Previously it was unlimited. After the release it's limited to 30sec by default. This is the PR to align documentation with current behaviour.

Pull request type

#182

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • Linter passes correctly
  • Add tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Does this introduce a breaking change?

  • Yes
  • No

Further comments

@render
Copy link

render bot commented Jul 13, 2022

@gontarzpawel gontarzpawel requested a review from mga-chka July 13, 2022 14:14
Copy link
Collaborator

@mga-chka mga-chka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're missing (at least) this line:

// if omitted or zero - no limits would be applied

@gontarzpawel gontarzpawel force-pushed the doc/change-following-breaking-change branch from 206c6ef to 99220c9 Compare July 13, 2022 15:26
@gontarzpawel gontarzpawel requested a review from mga-chka July 13, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants