Skip to content

feat: add dynamic text preview#5

Merged
eboukamza merged 5 commits intodevelopfrom
dynamic-text-preview
Jun 28, 2022
Merged

feat: add dynamic text preview#5
eboukamza merged 5 commits intodevelopfrom
dynamic-text-preview

Conversation

@aradjdi
Copy link
Copy Markdown
Collaborator

@aradjdi aradjdi commented Jun 17, 2022

No description provided.

Copy link
Copy Markdown
Contributor

@eboukamza eboukamza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I found some bugs when testing

  • text preview do not change when user change settings language
  • user not be able to edit text was empty

Comment thread apps/chrome-extension/src/views/SettingsMenu.vue Outdated
Comment thread apps/chrome-extension/src/views/SettingsMenu.vue Outdated
Comment thread apps/ms-word-addin/src/components/AdaptContainer.vue Outdated
Comment thread apps/ms-word-addin/src/components/AdaptContainer.vue Outdated
Comment thread apps/chrome-extension/src/components/AdaptContainer.vue Outdated
Comment thread apps/chrome-extension/src/components/AdaptContainer.vue Outdated
@eboukamza eboukamza force-pushed the dynamic-text-preview branch from 0ce3871 to 4e8d320 Compare June 28, 2022 07:10
@eboukamza eboukamza changed the title feat: add dynamic ext preview feat: add dynamic text preview Jun 28, 2022
@aradjdi aradjdi requested a review from a team June 28, 2022 10:22
@eboukamza eboukamza force-pushed the dynamic-text-preview branch from 4e8d320 to be5b08a Compare June 28, 2022 10:23
@eboukamza eboukamza merged commit 9b02d52 into develop Jun 28, 2022
@eboukamza eboukamza deleted the dynamic-text-preview branch June 28, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants