Add resource limits and cleanup to bridge and extension#190
Merged
Conversation
Implemented storage and cache size limits, periodic cleanup, and expiry for tokens, codes, and clients in the MCP bridge OAuth handler. Added request body size limit and graceful shutdown to the HTTP MCP server. Improved resource cleanup and cache pruning in the VSCode extension, including limiting skipped auth combos, clearing timers on deactivate, and disposing terminals properly.
🤖 Augment PR SummarySummary: This PR tightens resource usage and cleanup behavior across the MCP bridge and the VSCode uploader extension. Changes:
Technical Notes: Most changes focus on preventing memory growth (size caps + TTL eviction) and ensuring resources (clients, timers, terminals, HTTP server) are closed predictably. 🤖 Was this summary useful? React with 👍 or 👎 |
| body += chunk; | ||
| if (body.length > MAX_BODY_SIZE) { | ||
| bodyLimitExceeded = true; | ||
| req.destroy(); |
There was a problem hiding this comment.
| req.on("data", (chunk) => { | ||
| if (bodyLimitExceeded) return; | ||
| body += chunk; | ||
| if (body.length > MAX_BODY_SIZE) { |
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented storage and cache size limits, periodic cleanup, and expiry for tokens, codes, and clients in the MCP bridge OAuth handler. Added request body size limit and graceful shutdown to the HTTP MCP server. Improved resource cleanup and cache pruning in the VSCode extension, including limiting skipped auth combos, clearing timers on deactivate, and disposing terminals properly.