feat(transport): add category tag support to common schema announcements#73
Merged
Conversation
Add optional categories parameter to CommonToolSchemasOptions that enables including CEP-15 category tags in tools/list event announcements. Categories are normalized (trimmed whitespace) and deduplicated before being appended as 't' tags after the common-schema meta namespace tag. Includes unit and integration tests for the new functionality.
abhayguptas
approved these changes
May 19, 2026
Contributor
abhayguptas
left a comment
abhayguptas
left a comment
There was a problem hiding this comment.
I reviewed the implementation and ran the tests locally. The changes look clean and well-structured:
- The optional
categoriesparameter is fully backwards-compatible. - The
getAnnouncementCategorieshelper correctly handles edge cases like trailing whitespace, empty categories, and duplication. - The unit and integration tests cover all paths (deduplication, tag emission order, and empty states) and pass cleanly.
Everything is good to merge on my end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional categories parameter to CommonToolSchemasOptions that enables including CEP-15 category tags in tools/list event announcements. Categories are normalized (trimmed whitespace) and deduplicated before being appended as 't' tags after the common-schema meta namespace tag. Includes unit and integration tests for the new functionality.