Skip to content

Resource function for bcolz - #721

Merged
mrocklin merged 3 commits into
blaze:masterfrom
mrocklin:bcolz-resource
Oct 9, 2014
Merged

Resource function for bcolz#721
mrocklin merged 3 commits into
blaze:masterfrom
mrocklin:bcolz-resource

Conversation

@mrocklin

@mrocklin mrocklin commented Oct 9, 2014

Copy link
Copy Markdown
Member

No description provided.

@mrocklin

mrocklin commented Oct 9, 2014

Copy link
Copy Markdown
Member Author

Merging soon if no comment.

Comment thread blaze/bcolz.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be assigned to a variable?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Although really I should be using os.path.join

On Thu, Oct 9, 2014 at 1:41 PM, Phillip Cloud notifications@github.com
wrote:

In blaze/bcolz.py:

@@ -103,3 +107,18 @@ def into(a, b, *_kwargs):
def into(a, b, *_kwargs):
a.extend_chunks(chunks(b))
return a
+
+
+@resource.register('.+.bcolz/?')
+def resource_bcolz(rootdir, **kwargs):

  • rootdir.rstrip('/') + '/'

does this need to be assigned to a variable?


Reply to this email directly or view it on GitHub
https://github.com/ContinuumIO/blaze/pull/721/files#r18672694.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, actually, I don't need it at all anymore.

On Thu, Oct 9, 2014 at 1:42 PM, Matthew Rocklin mrocklin@continuum.io
wrote:

Yes! Although really I should be using os.path.join

On Thu, Oct 9, 2014 at 1:41 PM, Phillip Cloud notifications@github.com
wrote:

In blaze/bcolz.py:

@@ -103,3 +107,18 @@ def into(a, b, *_kwargs):
def into(a, b, *_kwargs):
a.extend_chunks(chunks(b))
return a
+
+
+@resource.register('.+.bcolz/?')
+def resource_bcolz(rootdir, **kwargs):

  • rootdir.rstrip('/') + '/'

does this need to be assigned to a variable?


Reply to this email directly or view it on GitHub
https://github.com/ContinuumIO/blaze/pull/721/files#r18672694.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@mrocklin mrocklin mentioned this pull request Oct 9, 2014
mrocklin added a commit that referenced this pull request Oct 9, 2014
@mrocklin
mrocklin merged commit 98ea9e9 into blaze:master Oct 9, 2014
@mrocklin
mrocklin deleted the bcolz-resource branch October 9, 2014 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants