Fix/non chrome fallback#368
Merged
pradeeban merged 1 commit intoControlCore-Project:devfrom Mar 21, 2026
Merged
Conversation
Author
|
Hey @pradeeban pls take a look, i think test failure is unrelated to this Pr |
Author
|
now working on the separate PR for other "bonus problems" such as the case sensitiveness, no file size limits etc as discussed :p |
Member
|
Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents crashes on browsers without full File System Access API support (Firefox/Safari) and falls back gracefully with existing user-facing messaging.
What changed:
Wrapped directory picker flow in try/catch and ignore cancel (AbortError).
Added guard for missing webkitRelativePath in directory upload fallback path.
Guarded createWritable() usage in graph save flow and fallback to existing save path when unavailable.
Updated file editor save checks to use feature detection instead of UA sniffing, with graceful fallback toast.
fixes #365