Skip to content

concoredocker.java: every API method is private, class is completely uncallable from outside #463

@avinxshKD

Description

@avinxshKD

Every method in concoredocker.java that a user would need to call is declared private static:

private static List<Object> read(int port, String name, String initstr)   // L152
private static void write(int port, String name, Object val, int delta)   // L278
private static boolean unchanged()                                         // L129
private static Object tryParam(String n, Object i)                        // L138

There is no main() method and no public interface. Any Java node that tries to call concoredocker.read(...) gets a compile error. The class cannot be used as a library and cannot run standalone. It is functionally dead code in its current form.

The fix would be, change private static to public static on all four API methods. The class already uses static state throughout, so making the methods public static is the correct pattern here (same as how the Python module-level functions work).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions