Skip to content

Conversation

@saksham-gera
Copy link
Contributor

No description provided.

@saksham-gera
Copy link
Contributor Author

Hi @pradeeban,

Please merge this.

I’m currently working on automatic port assignment based on edge labels. Since the mkconcore file is quite cluttered, making changes directly within it will likely take some time. I also need to fully understand the structure and logic of the file before I can properly integrate this functionality and begin testing.

Would you prefer that I commit a partially edited version of the file daily, or should I wait and push the fully integrated version after a couple of days?

Let me know what works best.

Thanks!

@pradeeban pradeeban merged commit eb0b7f0 into ControlCore-Project:dev Jun 7, 2025
@pradeeban
Copy link
Member

Thanks. Merged. Answering your question: You can commit your changes locally daily and then make the pull request once you are comfortable with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants