Skip to content

Comments

Add option to see realtime simulation#451

Merged
pradeeban merged 2 commits intoControlCore-Project:devfrom
GREENRAT-K405:dev
Feb 22, 2026
Merged

Add option to see realtime simulation#451
pradeeban merged 2 commits intoControlCore-Project:devfrom
GREENRAT-K405:dev

Conversation

@GREENRAT-K405
Copy link

@GREENRAT-K405 GREENRAT-K405 commented Feb 22, 2026

Hello @pradeeban @Rahuljagwani , This is the most easiest and minimal implementation to view realtime simulation,

We just need to pass "realtime=True" as one of the parameters (by default it is False to preserve backward compatibility).

The files I have touched here are only plotym.py , plotu.py, plotymlag.py under the tools dir.

Since we won't be touching already existing demo/ ratc samples, we have to create a new sample to demonstrate this.
This closes #445 .

@pradeeban
Copy link
Member

Yes, @GREENRAT-K405, much better now!

@pradeeban
Copy link
Member

@GREENRAT-K405 can you create a sample example code, even if just by simply calling an existing class and changing the method, or by having a minimal code copy-pasted and changed (perhaps a simplistic example such as the one presented in concore-lite?)

@GREENRAT-K405
Copy link
Author

@pradeeban right away! just give me few minutes.

@GREENRAT-K405
Copy link
Author

GREENRAT-K405 commented Feb 22, 2026

Screenshot 2026-02-23 024337 Hello @pradeeban , added a sample as you said. I have copied the nodes (pm2.py and controller2.py) from sample3 but took the plotym_CT from the updated plotting logic in tools/plotym.py

@GREENRAT-K405
Copy link
Author

Thanks a lot @pradeeban and @Rahuljagwani for such a detailed explanation and discussion yesterday. It's also an excellent brainstorming for me to find new feature to add and issues that can have good impact. Thanks a lot for your efforts!

@pradeeban
Copy link
Member

Awesome. Much better this way.

@pradeeban
Copy link
Member

pradeeban commented Feb 22, 2026

@GREENRAT-K405: Merging shortly. If @Rahuljagwani has follow up comments, you can raise another PR to address those.

@pradeeban pradeeban merged commit 02cf91c into ControlCore-Project:dev Feb 22, 2026
6 checks passed
@pradeeban
Copy link
Member

@GREENRAT-K405 a followup minor addition you can do is to record/document this feature and these examples somewhere in a README.md. Otherwise, this feature will be buried deep for us to forget eventually.

@GREENRAT-K405
Copy link
Author

Sure! will work right away on this.

@GREENRAT-K405
Copy link
Author

Also @pradeeban ,A small request to other fellow contributors (if anyone is reading this), please feel free to ask for collaboration rather just raising exact same issue with different title and description, and then raising a PR for the same that other contributor is already working on (this could cause waste of efforts on one side).
We should be having healthy collaborations, suggestions and discussion on big issues and features rather than unhealthy competition.

@pradeeban
Copy link
Member

@GREENRAT-K405, totally.

The GSoC application period is unfortunately too competitive and applicants race with the aim of quantity, rather than quality contributions and long-term success of the project. I think, this is somewhat a human nature in similar competitions. I don't think there is an easy fix, except for a simple observation that quantity does not matter as much as the quality of the contributions and the proposal itself.

This is more of a GSoC-specific situation though. In broader open-source world, there is no such competition to fix bugs or send PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants