Add option to see realtime simulation#451
Conversation
|
Yes, @GREENRAT-K405, much better now! |
|
@GREENRAT-K405 can you create a sample example code, even if just by simply calling an existing class and changing the method, or by having a minimal code copy-pasted and changed (perhaps a simplistic example such as the one presented in concore-lite?) |
|
@pradeeban right away! just give me few minutes. |
Hello @pradeeban , added a sample as you said. I have copied the nodes (pm2.py and controller2.py) from sample3 but took the plotym_CT from the updated plotting logic in tools/plotym.py
|
|
Thanks a lot @pradeeban and @Rahuljagwani for such a detailed explanation and discussion yesterday. It's also an excellent brainstorming for me to find new feature to add and issues that can have good impact. Thanks a lot for your efforts! |
|
Awesome. Much better this way. |
|
@GREENRAT-K405: Merging shortly. If @Rahuljagwani has follow up comments, you can raise another PR to address those. |
|
@GREENRAT-K405 a followup minor addition you can do is to record/document this feature and these examples somewhere in a README.md. Otherwise, this feature will be buried deep for us to forget eventually. |
|
Sure! will work right away on this. |
|
Also @pradeeban ,A small request to other fellow contributors (if anyone is reading this), please feel free to ask for collaboration rather just raising exact same issue with different title and description, and then raising a PR for the same that other contributor is already working on (this could cause waste of efforts on one side). |
|
@GREENRAT-K405, totally. The GSoC application period is unfortunately too competitive and applicants race with the aim of quantity, rather than quality contributions and long-term success of the project. I think, this is somewhat a human nature in similar competitions. I don't think there is an easy fix, except for a simple observation that quantity does not matter as much as the quality of the contributions and the proposal itself. This is more of a GSoC-specific situation though. In broader open-source world, there is no such competition to fix bugs or send PRs. |

Hello @pradeeban @Rahuljagwani , This is the most easiest and minimal implementation to view realtime simulation,
We just need to pass "realtime=True" as one of the parameters (by default it is False to preserve backward compatibility).
The files I have touched here are only plotym.py , plotu.py, plotymlag.py under the tools dir.
Since we won't be touching already existing demo/ ratc samples, we have to create a new sample to demonstrate this.
This closes #445 .