fix: resolve broken imports in cardiac_pm.py (#290)#526
Merged
pradeeban merged 2 commits intoControlCore-Project:devfrom Apr 1, 2026
Merged
Conversation
cardiac_pm.py in humanc/ and tools/ (symlinked by linktest/) imported pulsatile_model_functions and healthy_params directly, but these modules only exist inside the cardiac_pm.dir/ subdirectories. Add sys.path manipulation to insert the cardiac_pm.dir/ directory into the import path so the modules are found both during development and after deployment via mkconcore.py.
There was a problem hiding this comment.
Pull request overview
Fixes runtime import failures for the cardiac pulsatile model scripts by ensuring their sibling cardiac_pm.dir/ directories are discoverable on sys.path, aligning behavior across dev runs and mkconcore.py deployments.
Changes:
- Add
sys/osimports and asys.path.insert(...)to include the localcardiac_pm.dir/directory before importing model modules. - Reorder/move
loggingimport intools/cardiac_pm.pyto accommodate the path setup.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/cardiac_pm.py | Prepends tools/cardiac_pm.dir/ to sys.path so pulsatile_model_functions/healthy_params imports resolve. |
| humanc/cardiac_pm.py | Prepends humanc/cardiac_pm.dir/ to sys.path so pulsatile_model_functions/healthy_params imports resolve. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Guard sys.path.insert with a duplicate check to avoid accumulating entries on repeated imports/reloads (Copilot review suggestion). - Replace bare except with except (ValueError, SyntaxError) in sample/PZ/pm.py and sample/src/pm.py to fix ruff E722.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cardiac_pm.py in humanc/ and tools/ (symlinked by linktest/) imported pulsatile_model_functions and healthy_params directly, but these modules only exist inside the cardiac_pm.dir/ subdirectories.
Add sys.path manipulation to insert the cardiac_pm.dir/ directory into the import path so the modules are found both during development and after deployment via mkconcore.py.