Skip to content

Refactor with vue3 (draft)#10

Merged
ControlNet merged 36 commits intoControlNet:feature/vue3from
FeiBam:feature/vue3
Dec 21, 2022
Merged

Refactor with vue3 (draft)#10
ControlNet merged 36 commits intoControlNet:feature/vue3from
FeiBam:feature/vue3

Conversation

@FeiBam
Copy link

@FeiBam FeiBam commented Dec 15, 2022

Delete the old file of feature/vue3
Refactor the website with VUE3

@ControlNet ControlNet changed the title 合并分支 Refactor with vue3 Dec 15, 2022
@ControlNet ControlNet self-requested a review December 19, 2022 09:50
@ControlNet ControlNet force-pushed the feature/vue3 branch 3 times, most recently from 485f77e to d98f20d Compare December 19, 2022 10:02
Copy link
Owner

@ControlNet ControlNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need more work.

</el-col>
</el-row>
<el-row :justify="'space-between'" :align="'middle'">
<el-col :span="6"><h1>指标:</h1></el-col>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be replaced by i18n.

@ControlNet ControlNet self-requested a review December 20, 2022 16:31
Copy link
Owner

@ControlNet ControlNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Require more work.

}
return context.state.metaData
},
async getCsvDataBySelected(context){
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be placed here? Also, please consider improving the performance.

@ControlNet ControlNet self-requested a review December 21, 2022 18:52
@ControlNet ControlNet marked this pull request as draft December 21, 2022 18:53
Copy link
Owner

@ControlNet ControlNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current progress:

  • Coarse layout
  • Refined Navbar
  • HeatMap
    • Squares init and update
    • ColorMap interaction
    • Mouse and Tooltip interaction
    • LineChart and interaction
    • Table and interaction
  • Stacked Plot
  • Dark mode

CC: @n0099

@n0099
Copy link
Contributor

n0099 commented Dec 21, 2022

why mention me?

@ControlNet ControlNet merged commit 3ee7e01 into ControlNet:feature/vue3 Dec 21, 2022
@ControlNet ControlNet changed the title Refactor with vue3 Refactor with vue3 (draft) Dec 21, 2022
n0099 added a commit to n0099/open-tbm that referenced this pull request Sep 11, 2024
… original `loadChart` to replace the jquery-style directly mutating `Element.classList` with vue-style `v-bind:class=` directive @ pages/bilibiliVote.vue

* now will not recreate the intersection observer and using an static `rootMargin` for elements with the default `topOffset=0`, that currently is `header.thread-title` in `<PostRendererListThread>` @ stores/viewportTopmostPost.ts
* fix not expanding the start page without any cursor @ `<PostNav>`
* replace the only usage of `Number.parseInt()` with `Number()` to fix ControlNet/wt-data-project.web#10 (comment) @ utils/post/queryForm/index.ts
@ fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants