+ add method eventWrapper() to eliminate all self=this and curry returned function for event listeners#5
Merged
ControlNet merged 17 commits intoControlNet:mainfrom Nov 26, 2022
n0099:main
Merged
+ add method eventWrapper() to eliminate all self=this and curry returned function for event listeners#5ControlNet merged 17 commits intoControlNet:mainfrom n0099:main
ControlNet merged 17 commits intoControlNet:mainfrom
n0099:main
Conversation
…returned function for event listeners * now listening more generic pointer events which including both touch and mouse events @ init * rename all event listeners from `eventnameEvent` to `onEventName` @ `plot/br-heatmap.ts`.BrHeatmap
ControlNet
reviewed
Nov 22, 2022
Owner
ControlNet
left a comment
ControlNet
left a comment
There was a problem hiding this comment.
Line 49: Please remove unnecessary console.log.
Please consider to edit /src/plot/line-chart-ts as well.
* redo what we did in prev commit 18358f2 for `plot/br-heatmap.ts`.BrLineChart
ControlNet
requested changes
Nov 23, 2022
Owner
ControlNet
left a comment
ControlNet
left a comment
There was a problem hiding this comment.
Type checking error. Please revise the code.
Owner
|
Need revise the event listeners in |
…Element` since its usage `this.svg.on()` is requiring `ValueFn<SVGSVGElement, unknown, void>` @ event listeners() * pass the mousePos argu into `this.tooltip.update` @ onPointerMove() * import missing types @ `plot/line-chart.ts`.BrLineChart
ControlNet
reviewed
Nov 24, 2022
Owner
ControlNet
left a comment
ControlNet
left a comment
There was a problem hiding this comment.
It looks doesn't work on my end. Do you have any idea?
This reverts commit a281acf.
Contributor
Author
but wt-data-project.web/package.json Line 22 in dc94282 I suggest upgrade the ts version to 4.9 u've added the |
…returned function for event listeners * now listening more generic pointer events which including both touch and mouse events @ init * rename all event listeners from `eventnameEvent` to `onEventName` @ `plot/br-heatmap.ts`.BrHeatmap
* redo what we did in prev commit 18358f2 for `plot/br-heatmap.ts`.BrLineChart
…Element` since its usage `this.svg.on()` is requiring `ValueFn<SVGSVGElement, unknown, void>` @ event listeners() * pass the mousePos argu into `this.tooltip.update` @ onPointerMove() * import missing types @ `plot/line-chart.ts`.BrLineChart
…static method `BrHeatMap.eventWrapper()`
ControlNet
approved these changes
Nov 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eventnameEventtoonEventName@
plot/br-heatmap.ts.BrHeatmap