Skip to content

Conversation

@shroffk
Copy link
Member

@shroffk shroffk commented Jul 25, 2024

A simple formula for creating a VImage.

In the past we had many many scripts to handle channel access images
=imageOf(array_data, height, width, ...)

@shroffk shroffk requested a review from kasemir July 25, 2024 13:54
@kasemir kasemir merged commit 7f9c74d into master Jul 26, 2024
@kasemir kasemir deleted the imageOf branch July 26, 2024 16:06
@kasemir
Copy link
Collaborator

kasemir commented Jul 26, 2024

Bummer... Should these be removed?

import org.epics.pva.data.PVAByteArray;
import org.epics.pva.data.PVADoubleArray;
import org.epics.pva.data.PVAFloatArray;
import org.epics.pva.data.PVAIntArray;
import org.epics.pva.data.PVALongArray;
import org.epics.pva.data.PVAShortArray;

They're not used inside the new function, which makes sense because the function deals with VType data, not the underlying PVA... types.
So no need to import org.epics.pva.data.....
In fact must not do that, because now I get a build error:

[javac] 
..../phoebus/core/formula/src/main/java/org/csstudio/apputil/formula/areadetector/ImageOfFunction.java:11:
error: package org.epics.pva.data does not exist
    [javac] import org.epics.pva.data.PVAByteArray;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants