Image plot fixes #3166
Merged
Image plot fixes #3166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 11, 2024 14:09
When 'limits from PV' was used with a VImage (from PVA NTNDArray), the image axes would update to the size of the image whenever the PV sent a new value. But when the PV stayed constant and one would then perform operations that require a layout, like show/hide the toolbar, the image would be redrawn with the range from the model. The display would thus show the wrong axes range until the PV sent another update. Now the model axes are updated from the VImage, so the display sticks to the most recently received range from the VImage.
The image location on the screen used the old "dst_...". Now we compute the new layout and then "dst_.." values from the updated layout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When 'limits from PV' was used with a VImage (from PVA NTNDArray), the image axes would update to the size of the image whenever the PV sent a new value. But when the PV stayed constant and one would then perform operations that require a layout, like show/hide the toolbar, the image would be redrawn with the axes ranges from the model. The display would thus show the wrong axes until the PV sent another update.
Now the model axes are updated from the VImage, so the display sticks to the most recently received range from the VImage.
Similarly, when showing or hiding the toolbar, which changes the height of the image, the first update of the image would redraw in the old location on the screen.
Finally, the auto-scaling of the color bar failed when the value range was empty, for example all zeroes.