Fix conversion of OPI actions to execute scripts/commands into BOB #3341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently these cannot be parsed and so the actions get removed in the conveerted BOB.
The code was refactored to use auto-closing therefore the file does not need to be explictly closed.
|
+1 for the unit tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a few issues during the conversion of OPI to BOB when the widgets contained an action to EXECUTE_CMD, EXECUTE_PYTHONSCRIPT or EXECUTE_JAVASCRIPT. These are detailed in #3340.
This PR fixes the 3 issues detailed in the issue ticket above and also adds 2 Java unit tests to test this functionality to ensure we don't miss an regression to converter in the future.