-
Notifications
You must be signed in to change notification settings - Fork 115
CSSTUDIO-3429 (1) Restore label height fix and (2) Fix Byte Monitor widget #3537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
As far as I can see in my testing, the current implementation in this pull request fixes the bug in the Byte Monitor widget, and I consider the pull request ready to be merged. @rjwills28: You mention in #3533 that you can reproduce the issue with other widgets. Perhaps other widgets need should be fixed as well. I have, however, not been able to reproduce it with the Combo Box widget. Do you have a way of reproducing the issue with other widgets? |
|
After more testing, this pull request (and in particular commit 7c092bf) does lead to problems in the Navigation Tabs widget. If a Byte Monitor widget or a Linear Meter widget is part of an OPI that is displayed in the Navigation Tabs widget, then in perhaps 10-20% of the times the tab is opened, the widget will update very seldomly, perhaps at 20 or 30 second intervals or so. This can be observed by connecting the widget to a simulated PV of the form I have added back the tag |
|
Sorry: I jumped to my conclusion too quickly! In particular, the commit 7c092bf is not the cause of the observed issue. Rather, it seems to be the Waterfall Plot widget that was merged in #3520. I only observe the slow updates on the Byte Monitor and the Linear Meter when the Waterfall Plot widget from that pull request is running (the Waterfall Plot widget in another display than the one where the bug occurs!). The bug seems to disappear again after #3544. I don't have an explanation for this. I remove the |
This pull request:
The background for this pull request is described in issue #3533.
This is still a work-in-progress. In particular, more testing needs to be done, and perhaps the fix can be improved.