-
Notifications
You must be signed in to change notification settings - Fork 116
array down sampling with LTTB #3578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Added the missing documentation. |
|
This is cool! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since by default function arguments are initialized as VDouble in FormulaPV L66, ArraySampleWithLTTBFunction#compute() will throw an exception. For the same case ArrayScalarDivisionFunction returns DEFAULT_NAN_DOUBLE_ARRAY. Should this be aligned?
hmm... you are right, we should align this behaviour In some of the array functions we are throwing exceptions if an expected array argument is not one... but like you mention the initialization issue means we get at least one exception If we just return an nan array then how do we convey that the input is not of the correct type? |
|
You're right too, we need to highlight wrong type... But can we do it less verbose, the stack trace caught my eye which made me investigate it. |
|
A single line log message? a warning |
|
Personally I'd prefer single line, either warning or severe |
|
Maybe a warning including "....maybe due to mismatch in initial type" or similar |

Addresses #3577
Includes basic unit tests
Test are passing