Skip to content

Alarm apps#3707

Merged
shroffk merged 7 commits intomasterfrom
alarm_apps
Feb 26, 2026
Merged

Alarm apps#3707
shroffk merged 7 commits intomasterfrom
alarm_apps

Conversation

@shroffk
Copy link
Member

@shroffk shroffk commented Feb 25, 2026

Make the alarm logging and the alarm config logging services more resilient by making them poll for missing topics

If topics are deleted/removed/go missing then the services start throwing exceptions

Checklist

  • Testing:

    • The feature has automated tests
    • Tests were run
    • If not, explain how you tested your changes
  • Documentation:

    • The feature is documented
    • The documentation is up to date
    • Release notes:
      • Added an entry if the change is breaking or significant
      • Added an entry when adding a new feature

@lcaouen lcaouen requested a review from georgweiss February 25, 2026 11:02
@shroffk shroffk requested review from lcaouen February 25, 2026 11:09
@lcaouen
Copy link
Contributor

lcaouen commented Feb 25, 2026

tested with kafka 2.13

using master branch

  • start alarm server and alarm_logger services => I see alarms in Phoebus
  • delete topics => no more alarm
  • restart alarm_logger => get alarms so we need to restart the service with old version

using alarm branch (https://github.com/ControlSystemStudio/phoebus/tree/alarm_apps)

  • using new alarm_logger => start it, alarms are displayed
  • delete topics => no more alarm
  • restart alarm_logger => alarm logger subscribe again to kafka and get the alarm
  • however no message saying it's reconnecting successfully (see attachment)

out.txt

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
82.4% Duplication on New Code (required ≤ 3%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@lcaouen
Copy link
Contributor

lcaouen commented Feb 25, 2026

out.txt
New logs.
No more extra rest.SearchLogger logs

Copy link
Contributor

@lcaouen lcaouen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alarm logger subscribes automatically to kafka after deleting and recreating the topics.
Less unnecessary logs

@shroffk shroffk merged commit 8d5f00a into master Feb 26, 2026
4 of 5 checks passed
@shroffk shroffk deleted the alarm_apps branch February 26, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants