Skip to content

Fix for embedded images in Olog #3726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgweiss merged 1 commit into from
Mar 6, 2026
Merged

Fix for embedded images in Olog #3726

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/logbook/olog/ui/src/main/java/org/phoebus/logbook/olog/ui/OlogAttributeProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.phoebus.logbook.Attachment;
import java.util.List;
import org.apache.commons.io.FilenameUtils;
import org.phoebus.olog.es.api.OlogHttpClient;

/**
* An {@link AttributeProvider} used to style elements of a log entry. Other types of
Expand Down Expand Up @@ -76,7 +77,7 @@ public void setAttributes(org.commonmark.node.Node node, String s, Map<String, S
if (serviceUrl.endsWith("/")) {
serviceUrl = serviceUrl.substring(0, serviceUrl.length() - 1);
}
src = serviceUrl + "/" + src;
src = serviceUrl + "/" + OlogHttpClient.OLOG_PREFIX + "/" + src;
}
// If preview flag is true, the image url 'attachment/attachment_id'
// has to be converted to 'file://attachment_path'
Expand Down