Skip to content

Launcher: Fix loading bundled settings#3761

Merged
kasemir merged 1 commit intomasterfrom
bundled_settings
Apr 1, 2026
Merged

Launcher: Fix loading bundled settings#3761
kasemir merged 1 commit intomasterfrom
bundled_settings

Conversation

@kasemir
Copy link
Copy Markdown
Collaborator

@kasemir kasemir commented Apr 1, 2026

To detect bundled settings, that is a settings.ini file in the "install" location,
we check if a file with the expected absolute path is readable.
Next, however, we're loading just the "name", which results in this type of error:

INFO [org.phoebus.product] Loading bundled settings from
/Applications/CSS_Phoebus.app/product-xxxx/settings.ini
Exception in thread "main" java.lang.RuntimeException: Unable to locate
settings file: settings.ini
	at org.phoebus.framework.preferences.PropertyPreferenceLoader.load(PropertyPreferenceLoader.java:88)
	at org.phoebus.product.Launcher.loadSettings(Launcher.java:220)
	at org.phoebus.product.Launcher.main(Launcher.java:103)

Now it loads /Applications/CSS_Phoebus.app/product-xxxx/settings.ini as intended.

Checklist

  • Testing:
    • If not, explain how you tested your changes

SNS product recently failed with the error message shown above.
Works again after the fix.

Is checking the absolute path, but then loading just the "name", which
results in this type of error:

```
INFO [org.phoebus.product] Loading bundled settings from
/Applications/CSS_Phoebus.app/product-xxxx/settings.ini
Exception in thread "main" java.lang.RuntimeException: Unable to locate
settings file: settings.ini
	at org.phoebus.framework.preferences.PropertyPreferenceLoader.load(PropertyPreferenceLoader.java:88)
	at org.phoebus.product.Launcher.loadSettings(Launcher.java:220)
	at org.phoebus.product.Launcher.main(Launcher.java:103)
```

Now it loads `/Applications/CSS_Phoebus.app/product-xxxx/settings.ini`
as intended.
@kasemir kasemir merged commit 5949b94 into master Apr 1, 2026
3 checks passed
@kasemir kasemir deleted the bundled_settings branch April 1, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant