Fix double-layered DER decoding when reading X.509 certificate extension OIDs#3780
Merged
kasemir merged 1 commit intoControlSystemStudio:masterfrom Apr 15, 2026
Conversation
|
kasemir
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Problem
X509Certificate.getExtensionValue(oid)returns a DER-encodedOCTET STRINGwhose payload is itself another DER-encoded value (the actual extension content). The previous code only unwrapped one DER layer, so the certificate status PV name stored under OID1.3.6.1.4.1.37427.1was never correctly extracted.Fix
Unwrap both DER layers: first strip the outer
OCTET STRINGtag/length, then strip the innerOCTET STRINGtag/length to reach the raw UTF-8 string payload. This is required to correctly read any X.509v3 extension value viagetExtensionValue().This fix is only relevant when the client needs to locate the cert-status PV name from the peer's certificate; it has no effect on connections that do not use certificate status gating.
Files Changed
core/pva/src/main/java/org/epics/pva/common/SecureSockets.java