Skip to content

[Test] Optimize the speed of tests#4

Merged
ConvolutedDog merged 2 commits intomainfrom
dev
Sep 29, 2025
Merged

[Test] Optimize the speed of tests#4
ConvolutedDog merged 2 commits intomainfrom
dev

Conversation

@ConvolutedDog
Copy link
Copy Markdown
Owner

  • Restrict compilation rightness tests to GV100 only for faster validation
  • Use RTX 4090 exclusively for profiling functionality test
  • Reduce matmul problem size from 4096 to 1024 for quicker iterations
  • Remove H100 from test matrix to speedup the tests

- Restrict compilation rightness tests to GV100 only for faster validation
- Use RTX 4090 exclusively for profiling functionality test
- Reduce matmul problem size from 4096 to 1024 for quicker iterations
- Remove H100 from test matrix to speedup the tests
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ConvolutedDog, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly optimizes the execution speed of the test suite by strategically allocating specific test types to different GPU architectures, reducing the computational load of certain benchmarks, and streamlining the overall test matrix. The changes aim to provide faster validation and quicker iteration cycles for developers by focusing tests on the most efficient hardware for their purpose.

Highlights

  • Test Device Specialization: Compilation rightness tests are now exclusively run on NVIDIA GV100 GPUs, leveraging their faster profiling implementation, while profiling functionality tests are designated for NVIDIA RTX 4090 GPUs.
  • Matmul Problem Size Reduction: The problem size for matrix multiplication (matmul) tests has been significantly reduced from 4096 to 1024, leading to quicker test iterations and faster feedback.
  • H100 GPU Removal: The NVIDIA H100 GPU has been removed from the test matrix, further streamlining the test suite and contributing to overall speed optimization.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to optimize test execution speed by reducing the matmul problem size, removing H100 from the test matrix, and restricting specific tests to certain GPUs. The changes are generally well-aligned with these goals. However, I've identified a logic issue where a test intended exclusively for the RTX 4090 also runs on the GV100, which contradicts the PR's description and comments in the code. I've provided suggestions to correct this behavior in both of the modified test scripts.

@ConvolutedDog ConvolutedDog merged commit a81c2de into main Sep 29, 2025
1 check passed
@ConvolutedDog ConvolutedDog deleted the dev branch September 30, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant