Conversation
ConvolutedDog
commented
Sep 29, 2025
- Restrict compilation rightness tests to GV100 only for faster validation
- Use RTX 4090 exclusively for profiling functionality test
- Reduce matmul problem size from 4096 to 1024 for quicker iterations
- Remove H100 from test matrix to speedup the tests
- Restrict compilation rightness tests to GV100 only for faster validation - Use RTX 4090 exclusively for profiling functionality test - Reduce matmul problem size from 4096 to 1024 for quicker iterations - Remove H100 from test matrix to speedup the tests
Summary of ChangesHello @ConvolutedDog, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly optimizes the execution speed of the test suite by strategically allocating specific test types to different GPU architectures, reducing the computational load of certain benchmarks, and streamlining the overall test matrix. The changes aim to provide faster validation and quicker iteration cycles for developers by focusing tests on the most efficient hardware for their purpose. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to optimize test execution speed by reducing the matmul problem size, removing H100 from the test matrix, and restricting specific tests to certain GPUs. The changes are generally well-aligned with these goals. However, I've identified a logic issue where a test intended exclusively for the RTX 4090 also runs on the GV100, which contradicts the PR's description and comments in the code. I've provided suggestions to correct this behavior in both of the modified test scripts.