Skip to content

Build error with MSVC 19.41 #13

@emoose

Description

@emoose

Hi, thanks for the work on ModUtils, the Memory & Pattern code has been great to use!

OutRun2006Tweaks makes use of it, but recently github actions have been failing to build, eg: https://github.com/emoose/OutRun2006Tweaks/actions/runs/10584985216/job/29330534627
But the commit after that one built fine: https://github.com/emoose/OutRun2006Tweaks/actions/runs/10585142075/job/29331059552

Only difference I could see is the failed build using 19.41.34120.0 while successful build used the older 19.40.33813.0, updating my local VS also gives the same build error.

Not sure what could be wrong with the lines it complains about though:

ModUtils/Patterns.h

Lines 74 to 75 in 3d5474e

std::basic_string<uint8_t> m_bytes;
std::basic_string<uint8_t> m_mask;

Maybe something has changed and an extra include is now required there?

E: ah maybe microsoft/STL#4633 is the cause, adding _LEGACY_CODE_ASSUMES_STRING_VIEW_INCLUDES_XSTRING seems to let the build work.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions