Update IF97.h static BackwardRegionResidualElement CoeffTb23HS[]#40
Merged
ibell merged 1 commit intoCoolProp:masterfrom Aug 8, 2023
thermalogic:master
Merged
Update IF97.h static BackwardRegionResidualElement CoeffTb23HS[]#40ibell merged 1 commit intoCoolProp:masterfrom thermalogic:master
ibell merged 1 commit intoCoolProp:masterfrom
thermalogic:master
Conversation
static BackwardRegionResidualElement CoeffTb23HS[] http://www.iapws.org/relguide/Supp-phs3-2014.pdf. Eq 8 Page25 4.6 Equation TB23(h,s) for the Boundary between Regions 2 and 3 The last row is : {14, 1, 0.783237062349385E+07}};
Contributor
|
Can you please say more about the contents of this PR? |
Contributor
Author
The last row of 'static BackwardRegionResidualElement CoeffTb23HS[]' should be {14, 1, 0.783237062349385E+07}}; not please see the follow document for details: http://www.iapws.org/relguide/Supp-phs3-2014.pdf. Eq 8 Page25 4.6 Equation TB23(h,s) for the Boundary between Regions 2 and 3 |
Contributor
|
You mean the last coefficient in Table 25, right? That does indeed seem to be incorrect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
static BackwardRegionResidualElement CoeffTb23HS[]
http://www.iapws.org/relguide/Supp-phs3-2014.pdf. Eq 8 Page25 4.6 Equation TB23(h,s) for the Boundary between Regions 2 and 3
The last row is : {14, 1, 0.783237062349385E+07}};