Various Patches for pow(x,i) to powi(x,i), T_p() local vars, and lower p limit notifications#45
Merged
henningjp merged 4 commits intoCoolProp:masterfrom Jun 1, 2024
Merged
Conversation
… Fixes bkwd and xport functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits fix several issues:
pow(x,i)function introduced in Specialize pow for int. #43 causing errors in some compilers/settings wherestd::pow(x,y)was required; like in the reverse functions, region 3 Newton-Raphson solver and transport property equations. Renamed optimizedpow(x,i)function topowi(x,i)and used throughout forward IF97 function definitions where applicable. Closes Newton-Raphson failing in parts of Region 3 #44p_T(). Closes warning message for "A" variable - global declaration #42Testing
Full regression testing performed using Mathcad interface Verification Worksheet.
if97_validation2024.pdf
Tested upper/lower pressure limit checking in all treen IF97 temperature ranges for proper behavior.
