fix: explicitly mark semver releases as Latest#117
Merged
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
gh release createis invoked without--latest, leaving GitHub's default selector to decide which Release wears the "Latest" badge. When other Release objects exist (notably the floatingv1Release that has tracked the major version), GitHub can race and flip the badge to a non-semver release unpredictably.Fix
Add
--latestto thegh release createinvocation inpublish-release.ymlso every future semver release unambiguously claims Latest.Notes
v1Release object is being deleted separately as a one-shot ops action; this PR is defense in depth so the badge can never race again, regardless of what other Release objects exist now or in the future.Do not merge. Do not enable auto-merge.