Omnibus CR follow-up: 50+ fixes across recorder, providers, CI, competitive matrix#133
Merged
Omnibus CR follow-up: 50+ fixes across recorder, providers, CI, competitive matrix#133
Conversation
commit: |
54a524d to
79af244
Compare
4 tasks
jpr5
added a commit
that referenced
this pull request
Apr 23, 2026
…rock overrides + recorder correctness Folds PR #135 into PR #133. 5 commits: - CI workflow security hardening (5 workflows) - Cohere v2 complete parity (reasoning, webSearches, response_format, tool_calls, overrides) - Bedrock ResponseOverrides + stream format + Converse error wrapping - Recorder correctness (tool-call IDs, reasoning, multi-block text, empty-content, Ollama generate) - Router RegExp g-flag safety + test framework patchEnv save/restore + loadFixtures warnings
ccaf987 to
6ce5dfa
Compare
readBody 10MB size limit, control API error detail, one-shot race fix, normalizeCompatPath clarity, fixtures_loaded gauge updates on mutations, VideoStateMap TTL/bounds. JournalEntry source field, FixtureResponse type widening, matchesPattern JSDoc, isContentWithToolCallsResponse re-export.
headersSent guards, clientDisconnected tracking, content+toolCalls preservation, Cohere v2 detection, tool-call ID extraction (5 providers), reasoning extraction (4 providers), filter+join multi-block text, thinking-only/empty-content handling, Ollama /api/generate detection, streaming collapse reasoning propagation.
Bedrock/Converse: ContentWithToolCallsResponse, ResponseOverrides in all builders + streaming, Converse-wrapped stream events, text_delta type, error envelope, webSearches warnings. Cohere v2: reasoning, webSearches, response_format, tool_calls, full overrides. Ollama: content+toolCalls, stream default, validation. Gemini: callCounter collision fix, thought filtering. All: journal source field, Azure embedding routing.
computeChanges matches actual span class="no" structure, applyChanges regex matches td>span, updateProviderCounts scoped to competitor column, extractFeatures tightened keywords, added mokksy/ai-mocks competitor.
CI: --auto merge, Slack env vars (5 workflows), portable grep, injection prevention (jq). Router: lastIndex reset. Jest/Vitest: save/restore env vars, loadFixtures console.warn.
6ce5dfa to
6d3f4dc
Compare
6d3f4dc to
903acf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses all bucket (c) and (d) items from PR #122's 7-agent CR, plus correctness issues discovered during this PR's own iterative CR process (6 rounds, 4 fix cycles).
Server core
readBody10MB size limit (DoS surface closed)normalizeCompatPathmagic number replaced with readable expressionsourcefield ("fixture" | "proxy") added to JournalEntry typeRecorder correctness
headersSentguards,clientDisconnectedtracking, encoding_format loggingbuildFixtureResponsefilter+joininstead offind(Anthropic/Gemini/Bedrock)/api/generateformat detectionProvider handlers
text_deltatype field, Converse error envelope, webSearches warningsCompetitive matrix pipeline
computeChangesmatches actual HTML structure (span class="no")applyChangesregex matches actual td>span structureupdateProviderCountsscoped to competitor column (not global)extractFeaturestightened keyword patternsCI + framework
--autoinstead of--adminon fix-drift mergegrep -oE, SLACK_WEBHOOK guardsg-flaglastIndexresetTest plan
🤖 Generated with Claude Code