Recorder proxy hardening, server error handling, test hygiene#177
Merged
Conversation
- Forward HTTP method to upstream instead of hardcoding POST - Clear response timeout after successful completion (guard null socket) - Fix client-disconnect handler to check writableFinished before destroying - Wrap onHookBypassed and beforeWriteResponse callbacks in try/catch - Override audio content-type to application/json on non-2xx error relay - Atomic write (tmp+rename) for snapshot-mode fixture files - Sanitize undefined toolCall name/arguments before saving fixtures - Tighten video detection heuristic to exclude LLM provider fields - Clarify Float32Array alignment copy behavior
- Use consumed flag + deferred splice for one-shot error fixtures - Guard Azure model injection catch to only swallow SyntaxError - Pass matched fixture to evaluateChaos for non-completions endpoints - Cache fal request body to prevent double-consumption on passthrough - Include PUT in fal queue body reading
- Clean up previous tmpDir before overwriting in strict mode test - Replace global fetch with node:http helpers (del, postRaw) - Wrap default fixturePath test in try/finally for reliable cleanup - Hoist duplicate createRawUpstream to shared scope - Add explicit headersSent mock property instead of relying on internals - Guard setupUpstreamAndRecorder against leaked resources on re-entry - Narrow bare catch to only swallow expected filesystem errors
commit: |
1 task
jpr5
added a commit
that referenced
this pull request
May 13, 2026
## Summary Patch release v1.22.1 — includes strict-before-proxy fix (PR #182) + recorder hardening (PR #177). - Version bumped: package.json, plugin.json, marketplace.json, Chart.yaml - CHANGELOG [1.22.1] section with all unreleased fixes ## Test plan - [x] All version files bumped to 1.22.1 - [x] CHANGELOG updated - [x] Auto-publishes to npm on merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up quality sweep addressing 30 issues surfaced by 7-agent CR on PR #175, complementing the broader sweep in #176.
Recorder proxy relay — forward HTTP method instead of hardcoding POST, clear response timeout after completion, fix client-disconnect handler to check
writableFinishedbefore destroying upstream, wrap hook callbacks in try/catch, override audio content-type on error relay, atomic fixture writes, toolCall sanitization, tighter video detectionServer error handling — deferred splice for one-shot error fixtures, SyntaxError guard on Azure injection catch, fixture-level chaos evaluation for non-completions endpoints, fal body double-consumption fix, fal PUT body support
Test hygiene — tmpDir leak fix, global fetch replaced with node:http helpers, try/finally fixture cleanup, deduplicated helpers, explicit mock properties, resource guard on setup helper
Test plan