Fix watcher cleanup, empty-reload guard, and stale README#43
Merged
Conversation
commit: |
jpr5
force-pushed
the
fix/watcher-cleanup-and-readme
branch
from
81cc100 to
92f8769
Compare
jpr5
force-pushed
the
fix/watcher-cleanup-and-readme
branch
from
92f8769 to
b6d756f
Compare
jpr5
added a commit
that referenced
this pull request
Apr 3, 2026
## Summary Post-merge follow-up to PR #40. Addresses 3 findings from code review: - Watcher error handler now clears debounce timer and closes FSWatcher to avoid indeterminate state after fs.watch errors - Reload guards against replacing fixtures with empty array on parse failure, preserving previous working fixtures - Update README Future Direction to reflect that `--validate-on-load` and `validateFixtures()` now exist ## Test plan - [x] All 565 existing tests pass - [ ] Manually verify watcher error recovery (kill the watched file's filesystem) - [ ] Verify reload with invalid JSON preserves previous fixtures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-merge follow-up to PR #40. Addresses 3 findings from code review:
--validate-on-loadandvalidateFixtures()now existTest plan