Skip to content

Conversation

@msanatan
Copy link
Contributor

@msanatan msanatan commented Dec 29, 2025

These commits were meant to be a part of #491 but I had a computer error that stopped the first PR from being updated

Summary by Sourcery

Enhancements:

  • Improve clarity of the MCP For Unity menu by renaming the EditorPrefs entry to 'Edit EditorPrefs'.

Summary by CodeRabbit

  • UI/Style
    • Updated the editor menu label to "Edit EditorPrefs" for clearer navigation.
    • Refined the EditorPrefs window appearance by removing borders, eliminating border radius, and tightening spacing for a streamlined look.

✏️ Tip: You can customize this high-level summary in your review settings.

msanatan and others added 9 commits December 29, 2025 07:14
Meant to help with dev and testing, not so much the average user
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…c parsing

Replace complex sentinel-based type detection with a dictionary of known pref types and simple TryParse fallback for unknown keys. Remove null handling and HasKey checks for known keys since they're defined in EditorPrefKeys.
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 29, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Renames a Unity editor menu item for accessing the MCP EditorPrefs window to clarify its purpose; no functional logic changes are introduced.

File-Level Changes

Change Details Files
Rename the Unity menu item label for opening the MCP EditorPrefs window to be more descriptive.
  • Update the MenuItem attribute path string from 'Window/MCP For Unity/EditorPrefs' to 'Window/MCP For Unity/Edit EditorPrefs' to clarify that it edits editor preferences.
  • Leave the underlying ShowEditorPrefsWindow method implementation unchanged.
MCPForUnity/Editor/MenuItems/MCPForUnityMenu.cs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 29, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR updates the Unity editor menu item label from "EditorPrefs" to "Edit EditorPrefs" and refactors the EditorPrefsWindow styling by removing multiple borders, eliminating border-radius, and tightening spacing between preference items.

Changes

Cohort / File(s) Summary
Editor Menu Configuration
MCPForUnity/Editor/MenuItems/MCPForUnityMenu.cs
MenuItem attribute text updated from "Window/MCP For Unity/EditorPrefs" to "Window/MCP For Unity/Edit EditorPrefs"; priority remains unchanged.
EditorPrefs Window Styling
MCPForUnity/Editor/Windows/EditorPrefs/EditorPrefsWindow.uss
CSS refactor: removed left, right, and top borders (width 0); eliminated border-radius; reduced margin-bottom from 8px to 0. Bottom border retained.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Poem

🐰 A menu label tweaked with care,
And borders trimmed without a spare,
The UI grows more sleek and tight,
With styling polish, all feels right!
Hop-hop to cleaner editors bright! 🎨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c770a8c and 4e42ec5.

📒 Files selected for processing (2)
  • MCPForUnity/Editor/MenuItems/MCPForUnityMenu.cs
  • MCPForUnity/Editor/Windows/EditorPrefs/EditorPrefsWindow.uss

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@msanatan msanatan self-assigned this Dec 29, 2025
@msanatan msanatan merged commit 6f080f5 into CoplayDev:main Dec 29, 2025
0 of 2 checks passed
@msanatan msanatan deleted the edit-editor-configs branch December 29, 2025 17:40
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant