fix: strip spurious LIMIT when query already has TOP clause in MSSQL adapter#3
Merged
y11t0 merged 1 commit intoCoreBaseHQ:mainfrom Mar 22, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a user writes a T-SQL query using
SELECT TOP N ..., theQueryModifier(which uses a MySQL-dialect sqlparser) would appendLIMIT 1000to the query. The existingconvertLimitToTopfunction was supposed to handle this, but it had an early return whenTOPwas detected — leaving the trailingLIMITintact.The result was an invalid query like:
Which caused SQL Server to return:
Incorrect syntax near 'LIMIT'.Root Cause
In
convertLimitToTop, whenhasTopRematched, the function returned the query unchanged — even if a spuriousLIMIT Nhad already been appended byQueryModifier.Fix
When
TOPis detected and a trailingLIMITclause is also present, strip theLIMITclause instead of returning the query untouched.Test
Verified with a SQL Server query using
SELECT TOP 10:mssql: Sintaxe incorreta próxima a 'LIMIT'