arm64: dts: amlogic: set HDMI vendor info on vendor-branded boards#14
arm64: dts: amlogic: set HDMI vendor info on vendor-branded boards#14allolive wants to merge 1 commit into
Conversation
4e69fc2 to
3b1456a
Compare
|
Can you please rebase the PR? Also you might do the same for all other unique DTBs? |
f21681f to
0b9ff5d
Compare
|
@Portisch, I rebased and extended this to every vendor-branded boards in with similar issues. I used the existing model = "..." field on each board as the source for vendor_name / product_desc (first word → vendor, rest → product), with a couple of manual touches. Only tested on my AM6B+ (UGOOS/AM6B+ confirmed at runtime), so fingers crossed nothing got mis-named or broke for boards I don't have... |
|
Please also squash Missed DTS: s4_s905y4_buzztv_hd5
s5_s928x_tencent_aurora_5x
s5_s928x_x96_x10
s7d_s905x5m_xiaomi_3rd_gen
sm1_s905x3_buzztv_xrs4500
sm1_s905x3_starnet_apple_x3
sm1_s905x3_tiger_1b
sm1_s905x3_magicsee_c500_pro
sc2_s905x4_buzztv_u5
sc2_s905x4_buzztv_x5
c2_s905x4_sei_smb_280
sc2_s905x4_x96_x4When all this finished up we are good to merge! |
0b9ff5d to
809a58d
Compare
|
Please remove |
809a58d to
7440c98
Compare
|
Good catch. Done. |
|
I just did hit this issue: vendor: String representing the manufacturer (e.g., "AMD", "Intel", "NVIDIA"). Maximum 8 characters.
product: String describing the source device (e.g., "Radeon", "Core i7"). Maximum 16 characters.
|
|
@Portisch may I ask how did you test that? As for the updated vendor names, I propose the following changes:
If you're good with that, I'll push an update. |
|
This was a good job for AI, to filter it he changes and check the strings. Please update this PR now after merge of #16. I will check the to long strings later on. |
Override &amhdmitx vend_data on each vendor-branded board so AVRs/TVs
show the real product name in their HDMI input list instead of the
generic SoC name ("G12B", "SM1", ...) from the common dtsi.
Values come from each board's model = "..." field. vendor_name is
char[8] (max 7), product_desc char[16] (max 15); over-long vendor
names are abbreviated (Hardkrn, Sinovip, Homatic, Libre, Magic).
Signed-off-by: allolive <160342668+allolive@users.noreply.github.com>
7440c98 to
a9c80aa
Compare
The shared coreelec_g12b_common.dtsi sets the amhdmitx vend_data product_desc to "G12B" with the comment "Should modified by Customer". That generic SoC-family string is what AVRs and TVs display in their HDMI source / input list when they read the HDMI Vendor-Specific InfoFrame from the box.
Override the board's vend_data so the broadcast identifier matches the actual product instead of the generic SoC name.
Before:
$ cat /sys/firmware/devicetree/base/amhdmitx/vend_data/vendor_name
Amlogic
$ cat /sys/firmware/devicetree/base/amhdmitx/vend_data/product_desc
G12B # AVR shows "G12B"
After:
vendor_name = UGOOS
product_desc = AM6B+ # AVR shows "AM6B+"
This for all "G12B" variants hopefully.