Fixed rewriting the logger in logging middleware#8
Merged
miladz68 merged 1 commit intoCoreumFoundation:masterfrom Sep 5, 2022
miladz68:milad/fix/not-rewrite-logger-middleware
Merged
Fixed rewriting the logger in logging middleware#8miladz68 merged 1 commit intoCoreumFoundation:masterfrom miladz68:milad/fix/not-rewrite-logger-middleware
miladz68 merged 1 commit intoCoreumFoundation:masterfrom
miladz68:milad/fix/not-rewrite-logger-middleware
Conversation
wojtek-coreum
approved these changes
Sep 2, 2022
Collaborator
wojtek-coreum
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @begmaroman, @dzmitryhil, and @ysv)
ysv
reviewed
Sep 2, 2022
Collaborator
ysv
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @begmaroman, @dzmitryhil, and @miladz68)
http/errors.go line 25 at r1 (raw file):
err := next(c) if err != nil { logger := withEchoContext(logger, c)
that is why I always insist on not having name collisions with neither other variables or packages
non-blocking:
but can you please rename the var to smth different ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the logger gets rewritten on the middleware which is not correct, it should be copied and modified.
This change is