Small update to cwd_card_slider.js#74
Merged
dc774 merged 3 commits intoCornellCustomDev:mainfrom Feb 9, 2024
Merged
Conversation
As per Sean Gnau: This may have been incorrectly suggested otherwise in the past - but it is not okay to use aria-hidden on focusable elements. We cannot hide button controls from screen readers. Some screen reader users have vision, and use it to help read content, it is not okay to hide controls away from them.
Update cwd_card_slider.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per Sean Gnau:
This may have been incorrectly suggested otherwise in the past - but it is not okay to use aria-hidden on focusable elements. We cannot hide button controls from screen readers. Some screen reader users have vision, and use it to help read content, it is not okay to hide controls away from them.