Skip to content

Conversation

@alisonjo315
Copy link
Collaborator

@alisonjo315 alisonjo315 commented Apr 4, 2021

Closes #17

Available for review on CD Demo "alison" multidev:
https://alison-cd-demo.pantheonsite.io/

(I checked that no blocks were lost or re-ordered, nor were any config changes needed. Templates don't need updating, either, because the regions haven't changed, just the order of the regions as shown in Drupal admin UI.)

@alisonjo315 alisonjo315 requested a review from ama39 April 4, 2021 18:02
@alisonjo315
Copy link
Collaborator Author

@ama39 Could you please look at this region order, and tell me if it correctly reflects the order we render block regions (by default / on CD Demo)? -- here's the updated version of cwd_project.info.yml, or, I've pasted the regions: section here in this comment:


# These regions match the base theme, but will fully override the base theme's definitions. As such, you can add or remove regions as needed.
regions:
  nav_main: 'Main Navigation'
  nav_utility: 'Utility Navigation'
  nav_breadcrumb: 'Breadcrumb navigation'
  content_header: 'Content Header'
  content: 'Content'
  content_footer: 'Content Footer'
  sidebar_primary: 'Primary Sidebar (Top)'
  sidebar_secondary: 'Secondary Sidebar (Bottom)'
  supplementary: 'Supplementary Region 1'
  supplementary2: 'Supplementary Region 2'
  footer_primary: 'Primary Footer Region'
  footer_secondary: 'Secondary Footer Region'
  subfooter: 'Subfooter'

@alisonjo315 alisonjo315 removed the request for review from ama39 April 4, 2021 18:17
@alisonjo315 alisonjo315 merged commit 9067253 into main Jul 26, 2021
@alisonjo315 alisonjo315 deleted the regions branch July 26, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Order regions intuitively in theme info.yml

2 participants