Make sure JSON string values come through consistently as unicode.#366
Merged
leplatrem merged 1 commit intoCornices:masterfrom Nov 25, 2016
Merged
Make sure JSON string values come through consistently as unicode.#366leplatrem merged 1 commit intoCornices:masterfrom
leplatrem merged 1 commit intoCornices:masterfrom
Conversation
Contributor
leplatrem
approved these changes
Oct 19, 2016
Natim
reviewed
Oct 20, 2016
Contributor
Natim
left a comment
There was a problem hiding this comment.
Just a nitpick but it looks good to me thanks.
| are unicode when running using PY2. | ||
| """ | ||
|
|
||
| def test_extracted_json_values(self): |
Contributor
There was a problem hiding this comment.
Instead of doing the if not util.PY2 can we use the skipIf decorator here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you look at the current impl of
util.extract_json_datait passes request.body directly tosimplejson.loads.Under PY2, when passed a string,
loadshas the documented behaviour of varying the type of returned string values depending on the content of the strings:You can see the behaviour with e.g.:
The commit attached follows the advice of "decode s to unicode prior to calling loads" (when running under PY2 and when
request.bodyis astr).