fix(cli): verify task completion to detect partial responses#12
Merged
fix(cli): verify task completion to detect partial responses#12
Conversation
Fixes bounty issue #1506 The CLI run command now tracks whether a TaskComplete event was received. If the event stream ends without completion or an explicit error, it is treated as a partial response/error condition. This prevents misleading success status when the server disconnects prematurely.
echobt
force-pushed
the
fix/bounty-issue-1506
branch
from
2385843 to
d08da2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the CLI run command would exit with success status even if the server response was interrupted or incomplete. It now explicitly checks for a
TaskCompleteevent.Changes
completedflag to track if the task successfully finished.Related
Fixes PlatformNetwork/bounty-challenge#1506