Skip to content

feat(cortex-cli): implement 10 open PR features (#186)#189

Merged
echobt merged 3 commits intomasterfrom
feat/implement-10-cli-prs
Jan 27, 2026
Merged

feat(cortex-cli): implement 10 open PR features (#186)#189
echobt merged 3 commits intomasterfrom
feat/implement-10-cli-prs

Conversation

@echobt
Copy link
Contributor

@echobt echobt commented Jan 27, 2026

Summary

This PR implements 10 features from open pull requests for cortex-cli:

Implemented PRs

PR # Title Description
#98 Improve stats command message for new users Added informative output explaining what stats will track (sessions, tokens, costs, tools)
#99 Implement --share flag to display share URL Added cortex-share integration to share sessions and display share URL
#100 Warn when showing hidden agent details Added warning message when using 'agent show' on a hidden agent
#101 Standardize session ID error message format Changed error messages to use 'Invalid session ID format:' consistently
#102 Add --port option to debug wait command Added --port and --host options to wait for TCP port availability
#103 Validate empty prompt before authentication Added early validation of empty prompts in exec mode
#104 Add dynamic completion for agent names Added --names-only flag and shell completion helpers for agent names
#105 Document sandbox modes in help text Added documentation for sandbox modes (read-only, workspace-write, danger-full-access)
#106 Improve PR checkout confirmation message Enhanced checkout message to show source branch (e.g., 'from username:feature-branch')
#107 Correct help message to use lowercase Fixed 'fabric' to 'cortex' in login help message

Changes

  • stats_cmd.rs: Added informative output explaining what stats will track when no sessions exist
  • run_cmd.rs: Integrated cortex-share for session sharing functionality with --share flag
  • agent_cmd.rs: Added hidden agent warning and --names-only flag for shell completion
  • debug_cmd.rs: Added TCP port wait functionality with --port and --host options
  • export_cmd.rs: Standardized session ID error message format
  • main.rs: Added empty prompt validation, sandbox documentation, dynamic completion helpers
  • pr_cmd.rs: Enhanced checkout message to show source branch information
  • login.rs: Fixed command name in help text (fabric -> cortex)
  • Cargo.toml: Added cortex-share dependency

Testing

  • Ran cargo check -p cortex-cli - compiles successfully
  • Ran cargo fmt -p cortex-cli - code formatted properly

This commit implements the following features from open PRs:

- PR #98: Improve stats command message for new users with tracking info
- PR #99: Implement --share flag to display share URL using cortex-share
- PR #100: Warn when showing hidden agent details in 'agent show'
- PR #101: Standardize session ID error message format to 'Invalid session ID format:'
- PR #102: Add --port and --host options to debug wait command for TCP port checks
- PR #103: Validate empty prompt before authentication in exec mode
- PR #104: Add --names-only flag for dynamic shell completion of agent names
- PR #105: Document sandbox modes in help text with examples
- PR #106: Improve PR checkout confirmation to show source branch info
- PR #107: Correct help message to use lowercase 'cortex' command

Changes include:
- stats_cmd.rs: Added informative output explaining what stats will track
- run_cmd.rs: Added cortex-share integration for session sharing
- agent_cmd.rs: Added hidden agent warning and --names-only flag
- debug_cmd.rs: Added TCP port wait functionality with --port/--host
- export_cmd.rs: Standardized session ID error message
- main.rs: Added empty prompt validation, sandbox docs, dynamic completion
- pr_cmd.rs: Enhanced checkout message with source branch info
- login.rs: Fixed command name in help text
- Cargo.toml: Added cortex-share dependency
- Fixed duplicate import of get_cortex_home in login.rs
- Updated fabric_home to cortex_home in debug_cmd.rs
- Fixed run_logout call to include skip_confirmation parameter
- Re-added yes flag to LogoutCommand struct
@echobt echobt merged commit 59f5a37 into master Jan 27, 2026
4 of 12 checks passed
@echobt echobt deleted the feat/implement-10-cli-prs branch January 27, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants