fix(tui): restore cursor on Ctrl+C interrupt during spinner#2
Merged
Conversation
Fixes bounty issue #1522
The cursor remained hidden if the user interrupted the application with
Ctrl+C while a spinner was active. This was because the terminal
state wasn't fully restored in the Ctrl+C handler path.
This change explicitly calls terminal.show_cursor() when handling the
Ctrl+C interrupt signal in the event loop, ensuring the terminal
is left in a usable state.
echobt
force-pushed
the
fix/bounty-issue-1522
branch
from
d204d52 to
50ade49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where the terminal cursor remains hidden if the user interrupts the application with Ctrl+C while a spinner is active.
Changes
terminal.show_cursor()in the Ctrl+C handler path withinEventLoop::handle_engine_event.Testing
Related
Fixes PlatformNetwork/bounty-challenge#1522