fix(cortex-cli): accept uppercase shell names in completion command#22
Merged
fix(cortex-cli): accept uppercase shell names in completion command#22
Conversation
Fixes bounty issue #1551 The completion command now accepts shell names in any case (e.g., BASH, Bash, bash) by adding ignore_case = true to the shell argument attribute in CompletionCommand.
echobt
force-pushed
the
fix/bounty-issue-1551
branch
from
cc0d055 to
417a4d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue where the
cortex completioncommand rejects uppercase shell names (e.g.,BASH,ZSH).Changes
ignore_case = trueto the shell argument inCompletionCommandstructRelated
Fixes PlatformNetwork/bounty-challenge#1551