fix(mcp): keep server configuration inline in MCP panel#238
Merged
Conversation
Replace separate card/modal UI with inline form for Add MCP Server. Configuration now happens directly within the MCP Servers panel instead of opening a separate McpCard overlay. Changes: - Add InlineFormField and InlineFormState types for inline forms - Add form rendering support to InteractiveWidget - Add form input handling to interactive handlers - Add FormSubmitted result variant to InteractiveResult - Modify __add__ action to open inline form instead of McpCard - Add handle_inline_form_submission for processing form data This keeps the UX consistent - all MCP configuration stays in the same panel where servers are listed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace separate card/modal UI with inline form for Add MCP Server. Configuration now happens directly within the MCP Servers panel instead of opening a separate McpCard overlay.
Changes
InlineFormFieldandInlineFormStatetypes for inline forms ininteractive/state.rsInteractiveWidgetininteractive/renderer.rsFormSubmittedresult variant toInteractiveResult__add__action to open inline form instead of McpCardhandle_inline_form_submissionfor processing form dataRationale
The user requested that all MCP configuration stays in the existing MCP Servers panel:
Now when clicking "Add MCP Server", the form appears inline in this same panel rather than opening a separate card/modal.