fix(mcp): clarify ASCII-only requirement in server name validation error#24
Merged
fix(mcp): clarify ASCII-only requirement in server name validation error#24
Conversation
Fixes bounty issue #1626 The validate_server_name function uses is_ascii_alphanumeric() but the error message only mentioned 'letters, numbers' without specifying ASCII-only. Users trying unicode names like 'test-日本語' received a generic error without understanding why unicode characters were rejected. Updated the error message to explicitly state 'ASCII letters a-z/A-Z, digits 0-9' so users understand the limitation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When users try to add an MCP server with unicode characters in the name (e.g.,
mcp add test-日本語), the error message was unclear about why the name was rejected.Changes
validate_server_name()to explicitly state that only ASCII characters are alloweduse letters, numbers, '-', '_'touse ASCII letters a-z/A-Z, digits 0-9, '-', or '_'Related
Fixes PlatformNetwork/bounty-challenge#1626