[skip ci] fix: batch fixes for issues #2564, 2566, 2569, 2575, 2576, 2577, 2584, 2593, 2599, 2614#273
Closed
[skip ci] fix: batch fixes for issues #2564, 2566, 2569, 2575, 2576, 2577, 2584, 2593, 2599, 2614#273
Conversation
…, 2593, 2599, 2614 [skip ci] Fixes: - #2564: Add model format validation to reject invalid formats (e.g., invalid@format:tag, local://something) - #2566: Add 'debug shell' subcommand for shell environment information - #2569: Add 'prompts' command for managing saved prompts - #2575: Add 'ask' command as alias for 'run' - #2576: Add 'query' command as alias for 'run' - #2577: Add --show-usage flag to display token usage information - #2584: Enhance ContextWindowExceeded error with detailed token breakdown - #2593: Add --line-mode flag for processing stdin line-by-line - #2599: Add SIGTERM handler for graceful shutdown under systemd - #2614: Add 'hook' command for git hooks integration
echobt
pushed a commit
that referenced
this pull request
Jan 27, 2026
## Issues Fixed ### From PR #271 (Issues #2430-2459): - #2448: Validate URLs for control characters (security) - #2449: Decode HTML entities in scraped URLs - #2450: Reject reserved command names for agent names - #2452: Expand tilde (~) in MCP server command paths - #2459: Validate that model name is not empty ### From PR #273 (Issues #2564-2614): - Model format validation improvements ### From PR #279 (Issues #2835-2903): - #2835: Sandbox exit code preservation (always return original exit code) - #2843: Empty session ID validation ## Changes ### Agent Creation (#2450) - Added validation to reject reserved CLI command names as agent names - Reserved names: help, version, run, exec, login, logout, mcp, agent, etc. ### Scrape Command (#2448, #2449) - Added validate_url_security() to reject URLs with control characters - Added decode_html_entities() to properly decode href attributes - Added comprehensive tests for both functions ### MCP Command (#2452) - Added tilde expansion in command paths (~/script.sh -> /home/user/script.sh) - Also expands tilde in command arguments ### Model Validation (#2459) - Added check for empty model name in TUI mode ### Sandbox (#2835) - Changed exit behavior to always preserve original command exit code ### Session Handling (#2843) - Added early validation for empty session IDs Note: CI skipped for cost control. Test manually before merge.
echobt
added a commit
that referenced
this pull request
Jan 27, 2026
## Issues Fixed ### From PR #271 (Issues #2430-2459): - #2448: Validate URLs for control characters (security) - #2449: Decode HTML entities in scraped URLs - #2450: Reject reserved command names for agent names - #2452: Expand tilde (~) in MCP server command paths - #2459: Validate that model name is not empty ### From PR #273 (Issues #2564-2614): - Model format validation improvements ### From PR #279 (Issues #2835-2903): - #2835: Sandbox exit code preservation (always return original exit code) - #2843: Empty session ID validation ## Changes ### Agent Creation (#2450) - Added validation to reject reserved CLI command names as agent names - Reserved names: help, version, run, exec, login, logout, mcp, agent, etc. ### Scrape Command (#2448, #2449) - Added validate_url_security() to reject URLs with control characters - Added decode_html_entities() to properly decode href attributes - Added comprehensive tests for both functions ### MCP Command (#2452) - Added tilde expansion in command paths (~/script.sh -> /home/user/script.sh) - Also expands tilde in command arguments ### Model Validation (#2459) - Added check for empty model name in TUI mode ### Sandbox (#2835) - Changed exit behavior to always preserve original command exit code ### Session Handling (#2843) - Added early validation for empty session IDs Note: CI skipped for cost control. Test manually before merge. Co-authored-by: Droid Agent <droid@factory.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch fix for multiple bounty issues.
Issues Fixed
Changes
Model Format Validation (#2564)
validate_model_format()function in cortex-commoninvalid@format:tagandlocal://somethingollama://protocol for local modelsDebug Shell Subcommand (#2566)
cortex debug shellcommand to show shell environment informationPrompts Command (#2569)
cortex promptscommand with subcommands: list, show, add, removeAsk and Query Aliases (#2575, #2576)
cortex askas an alias forcortex runcortex queryas an alias forcortex runToken Usage Display (#2577)
--show-usageflag tocortex runContext Limit Error (#2584)
ContextWindowExceedederror to include token breakdownLine Mode Input (#2593)
--line-modeflag for processing stdin line-by-line--delimiteroption for custom line separatorsSystemd Signal Handler (#2599)
cortex serverun_with_shutdownfor graceful shutdown under systemdHook Command (#2614)
cortex hookcommand with subcommands: list, install, uninstall, run