fix(tui): use centralized auth module for subagent token propagation#298
Merged
fix(tui): use centralized auth module for subagent token propagation#298
Conversation
The UnifiedToolExecutor and CortexConfig were only checking the CORTEX_AUTH_TOKEN environment variable for authentication. This caused 401 errors when launching subagents for users authenticated via OAuth (keyring), since their tokens were stored in the system keyring, not in the environment variable. This fix uses the centralized auth_token module which properly checks: 1. Instance token (if provided) 2. CORTEX_AUTH_TOKEN environment variable 3. System keyring (via cortex_login with auto-refresh) Fixes: subagent 401 Unauthorized errors for OAuth-authenticated users
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When launching subagents (Task tool) in the TUI, users authenticated via OAuth (device code flow) were getting 401 Unauthorized errors:
This happened because the
UnifiedToolExecutorandCortexConfigwere only checking theCORTEX_AUTH_TOKENenvironment variable for authentication. OAuth tokens are stored in the system keyring, not in environment variables.Root Cause
In
app_runner.rs, when creating theUnifiedToolExecutor:And
get_api_keyonly checked the env var:Fix
Use the centralized
auth_tokenmodule which properly checks all authentication sources in priority order:CORTEX_AUTH_TOKENenvironment variableThis ensures subagent requests are authenticated the same way as the main session.
Changes
app_runner.rs: Usecortex_engine::auth_token::get_auth_token(None)for the UnifiedToolExecutorconfig.rs: Updateget_api_key,available_providers, andis_provider_availableto use the centralized auth moduleTesting
cargo checkpassescargo fmt --checkpassescargo +nightly build -rpasses