fix(terminal): resolve TypeScript errors in terminal components#308
Merged
fix(terminal): resolve TypeScript errors in terminal components#308
Conversation
- Fix TS2554: Pass search term argument to findNext/findPrevious in F3 handler - Fix TS2322: Properly format CSS position values with px units - Fix TS2484: Remove duplicate type exports in TerminalStickyScroll - Fix TS2353: Remove fastScrollModifier option not in xterm types - Clean up unused imports (batch, Input, Button, Text, Card) - Prefix unused variables with underscore for clarity - Export getPersistedSearchQuery from TerminalFind for external use Addresses terminal component TypeScript errors identified in AGENT3.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes TypeScript errors in the terminal components as identified in the AGENT3.md orchestration document.
Changes
TerminalPanel.tsx
findNext()andfindPrevious()calls in the F3 keyboard handler. These methods now correctly passgetPersistedSearchQuery()from TerminalFind.fastScrollModifierandfastScrollSensitivityoptions which don't exist in the current xterm.js types.TerminalQuickFix.tsx
batchimport from solid-js.infoandterminalIdparameters with underscore.TerminalStickyScroll.tsx
export typedeclarations that conflicted with already exported interfaces.getTrackerfunction with underscore.TerminalFind.tsx
getPersistedSearchQuery()export function to allow external access to the current search term.Testing