Conversation
- TestExplorer.tsx: Remove unused batch import, export getStatusColor/StatusFilterButton, add collapseAll button, fix Set<string> typing - CoverageBars.tsx: Remove unused onCleanup, fix SVG stroke-dasharray/dashoffset string types, prefix unused variables with underscore - CoverageView.tsx: Remove unused imports (batch, onMount, onCleanup, CoverageStats, CoverageChange), prefix tree-related variables for future use, fix Badge variant/size props - TestDecorations.tsx: Remove unused For/Show/Icon imports, fix glyphClass type annotation - TestCoverageOverlay.tsx: Remove unused LineCoverageStatus import, use void expression - TestOutputPanel.tsx: Remove unused onCleanup/tokens imports, fix testId duplicate property - DebugHoverWidget.tsx: Remove unused JSX/batch/isExpandable imports, prefix debug variable - ExceptionWidget.tsx: Remove unused ExceptionWidgetPosition import - BreakpointsView.tsx: Remove unused createMemo import These changes address TypeScript compilation warnings (TS6133/TS6196) and type errors in the testing panel and debug widget components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes TypeScript compilation errors and warnings in the testing panel (TestExplorer, CoverageBars, CoverageView) and debug widget components (DebugHoverWidget, ExceptionWidget, BreakpointsView).
Changes
Testing Components
TestExplorer.tsx:
batchimportgetStatusColorandStatusFilterButtonfor potential reusecollapseAllbutton to UI (pairs with existingexpandAll)Set<unknown>vsSet<string>typing issueCoverageBars.tsx:
onCleanupimportstroke-dasharray/stroke-dashoffsetto use string types_isHovered,_bgColor,isNegative) for future useCoverageView.tsx:
batch,onMount,onCleanup,CoverageStats,CoverageChange)TestDecorations.tsx:
For/Show/IconimportsglyphClassto fix type narrowingTestCoverageOverlay.tsx:
LineCoverageStatusimportvoidexpression instead of unused variable for reactivity triggerTestOutputPanel.tsx:
onCleanup/tokensimportstestIdduplicate property in exported dataDebug Components
DebugHoverWidget.tsx:
JSX/batch/DebugHoverResult/isExpandableimportsdebugvariableExceptionWidget.tsx:
ExceptionWidgetPositiontype importBreakpointsView.tsx:
createMemoimportTesting
npm run typecheckpasses for these filescargo fmt --checkpassesRelated
Part of AGENT 6 orchestration task for Testing & Coverage components analysis.