Skip to content

fix(gui): resolve TypeScript errors in testing and debug components#312

Merged
echobt merged 1 commit intomasterfrom
fix/agent6-testing-coverage-typescript-fixes
Jan 27, 2026
Merged

fix(gui): resolve TypeScript errors in testing and debug components#312
echobt merged 1 commit intomasterfrom
fix/agent6-testing-coverage-typescript-fixes

Conversation

@echobt
Copy link
Contributor

@echobt echobt commented Jan 27, 2026

Summary

This PR fixes TypeScript compilation errors and warnings in the testing panel (TestExplorer, CoverageBars, CoverageView) and debug widget components (DebugHoverWidget, ExceptionWidget, BreakpointsView).

Changes

Testing Components

  • TestExplorer.tsx:

    • Remove unused batch import
    • Export getStatusColor and StatusFilterButton for potential reuse
    • Add collapseAll button to UI (pairs with existing expandAll)
    • Fix Set<unknown> vs Set<string> typing issue
  • CoverageBars.tsx:

    • Remove unused onCleanup import
    • Fix SVG stroke-dasharray/stroke-dashoffset to use string types
    • Prefix unused variables (_isHovered, _bgColor, isNegative) for future use
  • CoverageView.tsx:

    • Remove unused imports (batch, onMount, onCleanup, CoverageStats, CoverageChange)
    • Prefix tree-related variables for future tree mode implementation
    • Fix Badge variant/size props to match component API
  • TestDecorations.tsx:

    • Remove unused For/Show/Icon imports
    • Add explicit type annotation to glyphClass to fix type narrowing
  • TestCoverageOverlay.tsx:

    • Remove unused LineCoverageStatus import
    • Use void expression instead of unused variable for reactivity trigger
  • TestOutputPanel.tsx:

    • Remove unused onCleanup/tokens imports
    • Fix testId duplicate property in exported data

Debug Components

  • DebugHoverWidget.tsx:

    • Remove unused JSX/batch/DebugHoverResult/isExpandable imports
    • Prefix unused debug variable
  • ExceptionWidget.tsx:

    • Remove unused ExceptionWidgetPosition type import
  • BreakpointsView.tsx:

    • Remove unused createMemo import

Testing

  • TypeScript errors in target components resolved
  • npm run typecheck passes for these files
  • cargo fmt --check passes

Related

Part of AGENT 6 orchestration task for Testing & Coverage components analysis.

- TestExplorer.tsx: Remove unused batch import, export getStatusColor/StatusFilterButton,
  add collapseAll button, fix Set<string> typing
- CoverageBars.tsx: Remove unused onCleanup, fix SVG stroke-dasharray/dashoffset string types,
  prefix unused variables with underscore
- CoverageView.tsx: Remove unused imports (batch, onMount, onCleanup, CoverageStats, CoverageChange),
  prefix tree-related variables for future use, fix Badge variant/size props
- TestDecorations.tsx: Remove unused For/Show/Icon imports, fix glyphClass type annotation
- TestCoverageOverlay.tsx: Remove unused LineCoverageStatus import, use void expression
- TestOutputPanel.tsx: Remove unused onCleanup/tokens imports, fix testId duplicate property
- DebugHoverWidget.tsx: Remove unused JSX/batch/isExpandable imports, prefix debug variable
- ExceptionWidget.tsx: Remove unused ExceptionWidgetPosition import
- BreakpointsView.tsx: Remove unused createMemo import

These changes address TypeScript compilation warnings (TS6133/TS6196) and type errors
in the testing panel and debug widget components.
@echobt echobt merged commit 3ee8839 into master Jan 27, 2026
1 of 3 checks passed
@echobt echobt deleted the fix/agent6-testing-coverage-typescript-fixes branch January 27, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants