fix(gui): resolve TypeScript errors in core shell components#318
Merged
fix(gui): resolve TypeScript errors in core shell components#318
Conversation
This commit fixes TypeScript errors in the core application shell components: - AppCore.tsx: Remove unused ErrorBoundary import - Layout.tsx: Fix unused imports, add proper useEventListeners import, replace non-existent tokens.motion with tokens.transitions, prefix unused variables/functions with underscore - LayoutContext.tsx: Remove unused batch import and prefix unused storage key - Panel.tsx: Remove unused onCleanup and layoutState imports, fix tokens.motion and non-existent token properties - SplitView.tsx: Remove unused ParentProps and resolveChildren imports - LayoutStore.ts: Remove unused SetStoreFunction import These fixes address the AGENT1.md checklist items for core and app shell components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes TypeScript errors in the core application shell components as identified in AGENT1.md.
Changes
AppCore.tsx
ErrorBoundaryimport (was causing TS6133)Layout.tsx
Box,VStack,MenuBarVisibility,useExtensions,AgentSkeleton)useEventListenersimport (was causing TS2552)tokens.motion.duration.Xwithtokens.transitions.X(motion doesn't exist in tokens)shouldHideSidebar,shouldCenterLayout,zenMaxWidth(zen mode features)RightSidebar,ActivityBarItem(reserved for future features)agentPanelCollapsed,AGENT_PANEL_COLLAPSED_WIDTH(collapsible agent panel)customPresets(user-defined layout presets)handleRightSidebarResize,handleAgentPanelResize(resize handlers)LayoutContext.tsx
batchimport from solid-jsSTORAGE_KEY_AUXILIARY_BARconstantPanel.tsx
onCleanupandlayoutStateimportstokens.sizes.icon.sm→ hardcoded16px(icon size doesn't exist in tokens)tokens.typography.letterSpacing.wide→ hardcoded0.05emtokens.motion.transition.fast→tokens.transitions.fastSplitView.tsx
ParentPropsandresolveChildrenimportsLayoutStore.ts
SetStoreFunctionimport from solid-js/storeTesting
Related
Addresses checklist items from
cortex-gui/orchestration/AGENT1.mdfor core and app shell components.