fix(cortex-cli): exit with non-zero code on JSON parse failure in import command#45
Merged
fix(cortex-cli): exit with non-zero code on JSON parse failure in import command#45
Conversation
…ort command Fixes bounty issue #1536 The import command was printing an error message when encountering malformed JSON but exiting with code 0. This fix ensures the process exits with code 1 when JSON parsing fails, allowing scripts and CI pipelines to properly detect the error condition.
echobt
force-pushed
the
fix/bounty-issue-1536
branch
from
b7eefb9 to
84284c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the
cortex importcommand prints an error message when encountering malformed JSON but exits with code 0 instead of a non-zero exit code.Changes
import_cmd.rsto explicitly print the error message and exit with code 1 when JSON parsing failsrunandloginTesting
When importing a malformed JSON file:
Related
Fixes PlatformNetwork/bounty-challenge#1536