fix(cli): exclude hidden elements from scrape command output#46
Merged
fix(cli): exclude hidden elements from scrape command output#46
Conversation
Fixes bounty issue #1707 The scrape command was including text from hidden DOM elements in its output. This fix adds visibility checks before processing elements to skip content that is hidden via: - hidden attribute - style="display:none" - style="visibility:hidden" - aria-hidden="true"
echobt
force-pushed
the
fix/bounty-issue-1707
branch
from
e923e7d to
ed7c5e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the scrape command to properly exclude hidden DOM elements from scraped content.
Changes
is_element_hidden()helper function to detect hidden elements via:hiddenattributestyle="display:none"style="visibility:hidden"aria-hidden="true"process_node_to_markdown()to skip hidden elementsextract_text_content()to skip hidden elementsRelated
Fixes PlatformNetwork/bounty-challenge#1707